[r] Provide reference to libtiledbsoma source via soft-link
#1372
Conversation
R CMD build does the right thing too
eddelbuettel
requested review from
Shelnutt2,
ihnorton,
aaronwolen,
johnkerl,
nguyenv and
mojaveazure
|
This pull request has been linked to Shortcut Story #28874: Examine viability of libtiledbsoma/ soft-link into apis/r/src/ to avoid source download. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
===========================================
- Coverage 65.11% 53.49% -11.63%
===========================================
Files 98 68 -30
Lines 7798 5382 -2416
===========================================
- Hits 5078 2879 -2199
+ Misses 2720 2503 -217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| #!/usr/bin/env Rscript | ||
|
|
||
| ## version pinning info | ||
| tiledb_core_version <- "2.15.2" |
There was a problem hiding this comment.
to minimize keystroking on future dependency-upgrade PRs, @gspowley wrote a very nice scripts/update-tiledb-version.py:
it looks like that script might not update this current script as-is -- ?
updating that script to handle this file might be done on this PR, or on a follow-up PR
There was a problem hiding this comment.
I wondered about that too but I thought the above was better because we only to change once for version and sha1 rather than three times (with largely redundant long URLs):
TileDB-SOMA/apis/r/tools/get_tarballs.R
Lines 8 to 19 in 326d5ea
Easy enough to revert if that is what we prefer. In tiledb-r I actually update two-line text 'key: value' text file that is then read (via a DCF reader R has in base so no need to worry about jaml or json...):
| @@ -0,0 +1 @@ | |||
| ../../../libtiledbsoma/ | |||
Let me know tomorrow or Sunday how it went. My score is pretty bright green at this point:
|
Issue and/or context:
The R package in
apis/rneeds thelibtiledbsomalibrary. Current package practice, when a build is required as no system installation is found is to bring the source in 'externally'. Using a soft-link back to the library source was considered at some point but discarded as it seemed unclear howgit,R(esp when build the 'release' tarball) and different file systems would react.It turns out that those fears were unfounded. Using a soft-link (even to a directory) works just fine in recent
git, andR CMD buildtransparently follows the link and includes the sources as a backup. This also works at r-universe per initial tests.This is an improved approach as it ties the usage of the library closer to the provision and minimises risk of slippage.
Changes:
As before, when a system library is seen no build is needed. If a build is needed, it is made with the source which are either included in the tar.gz or accessible when the repo is checked (as in the case of CI at GH Actions). The download step is skipped which allowed for a minor refactoring of the
configurescript which is again the only place from whichsrc/Makevarsis constructed. An extra wrinkle of testing for an 'out of $PATH'cmakewas added as needed at CRAN in case we ever upload (and/or this setup serves as model for other uses).Notes for Reviewer:
SC 28874